linux-kernel - Re: [Y2038] [PATCH v2 10/10] nanosleep: change time types to safe __kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1513297891.18523.295.camel@codethink.co.uk>
Date:   Fri, 15 Dec 2017 00:31:31 +0000
From:   Ben Hutchings <ben.hutchings@...ethink.co.uk>
To:     Deepa Dinamani <deepa.kernel@...il.com>, tglx@...utronix.de,
        john.stultz@...aro.org
Cc:     y2038@...ts.linaro.org, linux-api@...r.kernel.org,
        linux-kernel@...r.kernel.org, arnd@...db.de
Subject: Re: [Y2038] [PATCH v2 10/10] nanosleep: change time types to safe
 __kernel_* types

On Mon, 2017-11-27 at 11:30 -0800, Deepa Dinamani wrote:
[...]
> @@ -15,9 +16,7 @@ struct pollfd;
>  enum timespec_type {
>  	TT_NONE		= 0,
>  	TT_NATIVE	= 1,
> -#ifdef CONFIG_COMPAT
>  	TT_COMPAT	= 2,
> -#endif
>  };
>  
>  /*
> @@ -40,10 +39,8 @@ struct restart_block {
>  			clockid_t clockid;
>  			enum timespec_type type;
>  			union {
> -				struct timespec __user *rmtp;
> -#ifdef CONFIG_COMPAT
> +				struct __kernel_timespec __user *rmtp;
>  				struct compat_timespec __user *compat_rmtp;
> -#endif
>  			};
>  			u64 expires;
>  		} nanosleep;
[...]

The deletions of #ifdef and #endif here seem to belong in patch #6, as
that's the one that changes the condition for the compat nanosleep
implementation which uses the compat_rmtp field.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.