linux-kernel - Re: [PATCH v2 1/5] extcon: usbc-cros-ec: add support to notify USB type cables.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171215081453.6jwjdetwe655imqo@dell>
Date:   Fri, 15 Dec 2017 08:14:53 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Chanwoo Choi <cw00.choi@...sung.com>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Rob Herring <robh+dt@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>, groeck@...omium.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Benson Leung <bleung@...omium.org>
Subject: Re: [PATCH v2 1/5] extcon: usbc-cros-ec: add support to notify USB
 type cables.

> On 2017년 12월 13일 19:32, Enric Balletbo i Serra wrote:
> > From: Benson Leung <bleung@...omium.org>
> > 
> > Extend the driver to notify host and device type cables and the presence
> > of power.
> > 
> > Signed-off-by: Benson Leung <bleung@...omium.org>
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> > Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>
> > ---
> > Changes since v1:
> >  - Use the BIT macro. Requested by Lee Jones.
> >  - Add the Reviewed-by: Chanwoo Choi.
> > 
> >  drivers/extcon/extcon-usbc-cros-ec.c | 142 ++++++++++++++++++++++++++++++++++-
> >  include/linux/mfd/cros_ec_commands.h |  17 +++++
> >  2 files changed, 155 insertions(+), 4 deletions(-)

> Looks good to me. After reviewing the Lee Jones,
> I'll take it on next branch.

If you take it, you need to send me a pull-request to an immutable
branch.

Acked-by: Lee Jones <lee.jones@...aro.org>

-- 
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog