linux-kernel - RE: [PATCH] ASoC: nau8825: fix issue that pop noise when start capture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60213CA7255C53479ADE3BCF0360117F02E60DAB@PGSMSX103.gar.corp.intel.com>
Date:   Fri, 15 Dec 2017 08:21:15 +0000
From:   "Kumar, Abhijeet" <abhijeet.kumar@...el.com>
To:     John Hsu <KCHSU0@...oton.com>
CC:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        "Bhumika Goyal" <bhumirks@...il.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "anatol.pomozov@...il.com" <anatol.pomozov@...il.com>,
        "mhkuo@...oton.com" <mhkuo@...oton.com>,
        "wuchengli@...gle.com" <wuchengli@...gle.com>,
        "cychiang@...gle.com" <cychiang@...gle.com>,
        "Chiang, Mac" <mac.chiang@...el.com>,
        "YHCHuang@...oton.com" <YHCHuang@...oton.com>,
        "CTLIN0@...oton.com" <CTLIN0@...oton.com>,
        "WTLI@...oton.com" <WTLI@...oton.com>
Subject: RE: [PATCH] ASoC: nau8825: fix issue that pop noise when start
 capture

Need some help on next steps 
Who will do the review and patch merge?
Should i add any other mailing list to this thread?


-----Original Message-----
From: John Hsu [mailto:KCHSU0@...oton.com] 
Sent: Friday, December 15, 2017 12:47 PM
To: Kumar, Abhijeet <abhijeet.kumar@...el.com>
Cc: Liam Girdwood <lgirdwood@...il.com>; Mark Brown <broonie@...nel.org>; Jaroslav Kysela <perex@...ex.cz>; Takashi Iwai <tiwai@...e.com>; Bhumika Goyal <bhumirks@...il.com>; alsa-devel@...a-project.org; linux-kernel@...r.kernel.org; anatol.pomozov@...il.com; mhkuo@...oton.com; wuchengli@...gle.com; cychiang@...gle.com; Chiang, Mac <mac.chiang@...el.com>; YHCHuang@...oton.com; CTLIN0@...oton.com; WTLI@...oton.com
Subject: Re: [PATCH] ASoC: nau8825: fix issue that pop noise when start capture

On 12/12/2017 3:10 AM, abhijeet.kumar@...el.com wrote:
> From: Abhijeet Kumar <abhijeet.kumar@...el.com>
>
> In skylake platform, we hear a loud pop noise(0 dB) at start of audio 
> capture power up sequence. This patch removes the pop noise from the 
> recording by adding a delay before enabling ADC.
>
> Signed-off-by: Abhijeet Kumar <abhijeet.kumar@...el.com>
> ---
>  sound/soc/codecs/nau8825.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c 
> index 714ce17da717..e853a6dfd33b 100644
> --- a/sound/soc/codecs/nau8825.c
> +++ b/sound/soc/codecs/nau8825.c
> @@ -905,6 +905,7 @@ static int nau8825_adc_event(struct 
> snd_soc_dapm_widget *w,
>
>       switch (event) {
>       case SND_SOC_DAPM_POST_PMU:
> +             msleep(125);
>               regmap_update_bits(nau8825->regmap, NAU8825_REG_ENA_CTRL,
>                       NAU8825_ENABLE_ADC, NAU8825_ENABLE_ADC);
>               break;

The solution is fine for me. It's verified in my device and indeed helps to reduce the capture pop noise. I think the little delay is acceptable.



===========================================================================================
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.