linux-kernel - Re: [PATCH V2] ACPI / LPSS: Add device link for CHT SD card dependency on I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1513332217.7000.81.camel@linux.intel.com>
Date:   Fri, 15 Dec 2017 12:03:37 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Carlo Caione <carlo@...lessm.com>,
        Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH V2] ACPI / LPSS: Add device link for CHT SD card
 dependency on I2C

On Fri, 2017-12-15 at 01:58 +0100, Rafael J. Wysocki wrote:
> On Thu, Dec 14, 2017 at 3:16 PM, Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> > On Thu, 2017-12-07 at 11:03 +0200, Adrian Hunter wrote:
> > > 

> > > 
> > > +static const struct x86_cpu_id cht_cpu[] = {
> > > +     ICPU(INTEL_FAM6_ATOM_AIRMONT),  /* Braswell, Cherry
> > > Trail */
> > > +     {}
> > > +};
> > 
> > I would rather to modify ICPU() macro to accept driver data where we
> > just pass an unsigned long value to be assigned as lpss_quirks and
> > introduce another quirk.
> 
> Not really.
> 
> There are many instances of ICPU() already in the tree and updating
> all of them is just not worth it.

These macros all over the code are local.
I'm talking about one which is defined inside acpi_lpss.c.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy