linux-kernel - [PATCH 4.4 044/105] module: set __jump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171215092308.194000839@linuxfoundation.org>
Date:   Fri, 15 Dec 2017 10:44:42 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, Jason Baron <jbaron@...mai.com>,
        Jessica Yu <jeyu@...hat.com>,
        Sachin Sant <sachinp@...ux.vnet.ibm.com>,
        David Daney <david.daney@...ium.com>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Sasha Levin <alexander.levin@...izon.com>
Subject: [PATCH 4.4 044/105] module: set __jump_table alignment to 8

4.4-stable review patch.  If anyone has any objections, please let me know.

------------------

From: David Daney <david.daney@...ium.com>


[ Upstream commit ab42632156becd35d3884ee5c14da2bedbf3149a ]

For powerpc the __jump_table section in modules is not aligned, this
causes a WARN_ON() splat when loading a module containing a __jump_table.

Strict alignment became necessary with commit 3821fd35b58d
("jump_label: Reduce the size of struct static_key"), currently in
linux-next, which uses the two least significant bits of pointers to
__jump_table elements.

Fix by forcing __jump_table to 8, which is the same alignment used for
this section in the kernel proper.

Link: http://lkml.kernel.org/r/20170301220453.4756-1-david.daney@cavium.com

Reviewed-by: Jason Baron <jbaron@...mai.com>
Acked-by: Jessica Yu <jeyu@...hat.com>
Acked-by: Michael Ellerman <mpe@...erman.id.au> (powerpc)
Tested-by: Sachin Sant <sachinp@...ux.vnet.ibm.com>
Signed-off-by: David Daney <david.daney@...ium.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
Signed-off-by: Sasha Levin <alexander.levin@...izon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
---
 scripts/module-common.lds |    2 ++
 1 file changed, 2 insertions(+)

--- a/scripts/module-common.lds
+++ b/scripts/module-common.lds
@@ -19,4 +19,6 @@ SECTIONS {
 
 	. = ALIGN(8);
 	.init_array		0 : { *(SORT(.init_array.*)) *(.init_array) }
+
+	__jump_table		0 : ALIGN(8) { KEEP(*(__jump_table)) }
 }