linux-kernel - Re: [PATCH] phy: rcar-gen3-usb2: add dependency on USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7daf2030-4030-7072-1d2e-3905cbf1ab33@arm.com>
Date:   Fri, 15 Dec 2017 10:28:59 +0000
From:   Vladimir Murzin <vladimir.murzin@....com>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Cc:     "horms+renesas@...ge.net.au" <horms+renesas@...ge.net.au>,
        "kishon@...com" <kishon@...com>, "arnd@...db.de" <arnd@...db.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: rcar-gen3-usb2: add dependency on USB

Hi,

On 15/12/17 10:27, Yoshihiro Shimoda wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Vladimir Murzin, Sent: Friday, December 15, 2017 7:20 PM
>>
>> Following error showed up:
>>
>> drivers/phy/renesas/phy-rcar-gen3-usb2.o: In function `rcar_gen3_phy_usb2_probe':
>> /work/tools/linux/drivers/phy/renesas/phy-rcar-gen3-usb2.c:444: undefined reference to `of_usb_get_dr_mode_by_phy'
>> Makefile:993: recipe for target 'vmlinux' failed
>> make: *** [vmlinux] Error 1
>>
>> with CONFIG_USB_SUPPORT=n
>>
>> Add dependency on USB_SUPPORT and select USB_COMMON to make sure that
>> of_usb_get_dr_mode_by_phy() is available.
>>
>> Signed-off-by: Vladimir Murzin <vladimir.murzin@....com>
> 
> Thank you for the patch! However, Arnd already sent such a patch before.
> 
> https://lkml.org/lkml/2017/11/2/373
> 
> The latest Linux-phy.git doesn't apply it yet though...

Ahh, good!

Sorry for the noise!

Vladimir

> 
> Best regards,
> Yoshihiro Shimoda
>