lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 15 Dec 2017 12:56:16 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        alsa-devel@...nel.org
Cc:     tiwai@...e.de, broonie@...nel.org, torvalds@...ux-foundation.org,
        vinod.koul@...el.com, liam.r.girdwood@...ux.intel.com,
        arnd@...db.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/9] ASoC: Intel: document what Kconfig options do

On Thu, 2017-12-14 at 18:44 -0600, Pierre-Louis Bossart wrote:
> Document in comments what the options are supposed to mean, before
> clean-up in next patch.

> +config SND_SOC_INTEL_SST_ACPI
> +	tristate
> +	# This option controls ACPI-based probing on
> Haswell/Broadwell/
> +	#  Baytrail legacy and will be set when these platforms are
> enabled

I would rather start a new line (mind indentation as well) with list of
platforms:

# This option controls ACPI-based probing on
# Haswell/Broadwell/Baytrail legacy and will be set
# when these platforms are enabled

> +	# This option controls firmware download on
> Haswell/Broadwell/
> +	# Baytrail legacy and will be set when these platforms are
> enabled

Ditto,

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ