linux-kernel - Re: [PATCH v5 5/7] scsi: libsas: use flush_workqueue to process disco events synchronously

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44a05f30-b21a-e9c4-7f34-a2abb3859332@suse.de>
Date:   Fri, 15 Dec 2017 13:21:22 +0100
From:   Hannes Reinecke <hare@...e.de>
To:     Jason Yan <yanaijie@...wei.com>, martin.petersen@...cle.com,
        jejb@...ux.vnet.ibm.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        john.garry@...wei.com, zhaohongjiang@...wei.com, hare@...e.com,
        dan.j.williams@...el.com, jthumshirn@...e.de,
        Raj.Dinesh@...rosemi.com, hch@....de, huangdaode@...ilicon.com,
        chenxiang66@...ilicon.com, xiyou.wangcong@...il.com,
        Ewan Milne <emilne@...hat.com>, Tomas Henzl <thenzl@...hat.com>
Subject: Re: [PATCH v5 5/7] scsi: libsas: use flush_workqueue to process disco
 events synchronously

On 12/08/2017 10:42 AM, Jason Yan wrote:
> Now we are processing sas event and discover event in different workqueues.
> It's safe to wait the discover event done in the sas event work. Use
> flush_workqueue() to insure the disco and revalidate events processed
> synchronously so that the whole discover and revalidate process will not
> be interrupted by other events.
> 
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> CC: John Garry <john.garry@...wei.com>
> CC: Johannes Thumshirn <jthumshirn@...e.de>
> CC: Ewan Milne <emilne@...hat.com>
> CC: Christoph Hellwig <hch@....de>
> CC: Tomas Henzl <thenzl@...hat.com>
> CC: Dan Williams <dan.j.williams@...el.com>
> ---
>  drivers/scsi/libsas/sas_port.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/scsi/libsas/sas_port.c b/drivers/scsi/libsas/sas_port.c
> index 9326628..64722f4 100644
> --- a/drivers/scsi/libsas/sas_port.c
> +++ b/drivers/scsi/libsas/sas_port.c
> @@ -192,6 +192,7 @@ static void sas_form_port(struct asd_sas_phy *phy)
>  		si->dft->lldd_port_formed(phy);
>  
>  	sas_discover_event(phy->port, DISCE_DISCOVER_DOMAIN);
> +	flush_workqueue(sas_ha->disco_q);
>  }
>  
>  /**
> @@ -277,6 +278,9 @@ void sas_porte_broadcast_rcvd(struct work_struct *work)
>  
>  	SAS_DPRINTK("broadcast received: %d\n", prim);
>  	sas_discover_event(phy->port, DISCE_REVALIDATE_DOMAIN);
> +
> +	if (phy->port)
> +		flush_workqueue(phy->port->ha->disco_q);
>  }
>  
>  void sas_porte_link_reset_err(struct work_struct *work)
> 
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@...e.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)