linux-kernel - Re: [PATCH 2/9] ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d02951a-63d3-eb33-142e-46f16612626b@linux.intel.com>
Date:   Fri, 15 Dec 2017 06:34:02 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        alsa-devel@...a-devel.org
Cc:     tiwai@...e.de, broonie@...nel.org, torvalds@...ux-foundation.org,
        vinod.koul@...el.com, liam.r.girdwood@...ux.intel.com,
        arnd@...db.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/9] ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI
 dependencies

On 12/15/17 4:58 AM, Andy Shevchenko wrote:
> On Thu, 2017-12-14 at 18:44 -0600, Pierre-Louis Bossart wrote:
>> PCI/ACPI selections should not happen in Kconfig for machine drivers,
>> move to SOC selections.
>>
>> Add distinction between PCI and ACPI HiFi2 platforms and help text.
>>
>> There should be no functionality change.
>>
>> The PCI-based platforms may be removed at some point since Medfield
>> is not really supported by anyone, and with Edison now defunct support
>> for
>> Merrifield/Edison is to be determined.
>>
> 
>> -	depends on SND_DMA_SGBUF
>> +	depends on SND_DMA_SGBUF && ACPI
>>   	depends on DMADEVICES
> 
> Perhaps
> 
> depends on DMADEVICES && ACPI
> 
> to be in align with below?
> 
>>   config SND_SOC_INTEL_BAYTRAIL
>>   	tristate "Intel ASoC SST driver for Baytrail (legacy)"
>> -	depends on DMADEVICES
>> +	depends on DMADEVICES && ACPI

I must admit I don't know why it's different, I just cleaned-up what I 
could. Maybe Liam can comment since I believe he contributed to both 
Haswell and the initial Baytrail driver?