linux-kernel - Re: [PATCH] mm: thp: avoid uninitialized variable use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171215130315.GZ16951@dhcp22.suse.cz>
Date:   Fri, 15 Dec 2017 14:03:15 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Vlastimil Babka <vbabka@...e.cz>,
        David Rientjes <rientjes@...gle.com>,
        Ingo Molnar <mingo@...nel.org>,
        Yang Shi <yang.s@...baba-inc.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: thp: avoid uninitialized variable use

On Fri 15-12-17 13:51:04, Arnd Bergmann wrote:
> When the down_read_trylock() fails, 'vma' has not been initialized
> yet, which gcc now warns about:
> 
> mm/khugepaged.c: In function 'khugepaged':
> mm/khugepaged.c:1659:25: error: 'vma' may be used uninitialized in this function [-Werror=maybe-uninitialized]

ups missed that

> 
> Presumable we are not supposed to call find_vma() without the mmap_sem
> either, so setting it to NULL for this case seems appropriate.

yes

> Fixes: 0951b59acf3a ("mm: thp: use down_read_trylock() in khugepaged to avoid long block")

This sha is not stable because this is a mmotm tree. I assume Andrew will fold
it to mm-thp-use-down_read_trylock-in-khugepaged-to-avoid-long-block.patch.
The patch looks good to me. I would initialize the vma in the
declaration, but that is a minor thing.

> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Michal Hocko <mhocko@...e.com>

> ---
> I'm not completely sure this patch is sufficient, it gets rid of
> the warning, but it would be good to have the code reviewed better
> to see if other problems remain that result from down_read_trylock()
> patch.
> ---
>  mm/khugepaged.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index 521b908f9600..b7e2268dfc9a 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -1677,11 +1677,10 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages,
>  	 * Don't wait for semaphore (to avoid long wait times).  Just move to
>  	 * the next mm on the list.
>  	 */
> +	vma = NULL;
>  	if (unlikely(!down_read_trylock(&mm->mmap_sem)))
>  		goto breakouterloop_mmap_sem;
> -	if (unlikely(khugepaged_test_exit(mm)))
> -		vma = NULL;
> -	else
> +	if (likely(!khugepaged_test_exit(mm)))
>  		vma = find_vma(mm, khugepaged_scan.address);
>  
>  	progress++;
> -- 
> 2.9.0
> 

-- 
Michal Hocko
SUSE Labs