linux-kernel - Re: [PATCH] rtc: ds1307: call the platform's logic for handle IRQs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171215130425.GA7022@piout.net>
Date:   Fri, 15 Dec 2017 14:04:25 +0100
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Enric Balletbo Serra <eballetbo@...il.com>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-rtc@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtc: ds1307: call the platform's logic for handle IRQs.

Hi,

On 15/12/2017 at 12:44:49 +0100, Enric Balletbo Serra wrote:
> Hi,
> 
> 2017-08-24 12:30 GMT+02:00 Enric Balletbo i Serra
> <enric.balletbo@...labora.com>:
> > On some systems the nIRQ pin is often connect to a GPIO, then, if a given
> > interrupt line is supposed to wake up the system, the corresponding input
> > of that interrupt controller need to be enabled to receive signal from the
> > line in question. Before this commit such systems would not wake up
> > because are not marked as wakeup IRQs in the IRQ subsystem.
> >
> > This commit calls enable_irq_wake() on suspend and disables that input to
> > prevent the dedicated controller from triggering interrupts unnecessarily
> > after wakeup.
> >
> > After this commit a system composed by a RTC DS1339 chip connected to a
> > GPIO line on a AM335x SoC is able to wakeup from suspend-to-RAM, otherwise
> > the line is ignored.
> >
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> > ---
> >  drivers/rtc/rtc-ds1307.c | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >
> > diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
> > index 4b43aa6..c4b0f6a 100644
> > --- a/drivers/rtc/rtc-ds1307.c
> > +++ b/drivers/rtc/rtc-ds1307.c
> > @@ -1711,11 +1711,36 @@ static int ds1307_probe(struct i2c_client *client,
> >         return err;
> >  }
> >
> > +#ifdef CONFIG_PM_SLEEP
> > +static int ds1307_suspend(struct device *dev)
> > +{
> > +       struct ds1307 *ds1307 = dev_get_drvdata(dev);
> > +
> > +       if (device_may_wakeup(dev))
> > +               enable_irq_wake(ds1307->irq);
> > +
> > +       return 0;
> > +}
> > +
> > +static int ds1307_resume(struct device *dev)
> > +{
> > +       struct ds1307 *ds1307 = dev_get_drvdata(dev);
> > +
> > +       if (device_may_wakeup(dev))
> > +               disable_irq_wake(ds1307->irq);
> > +
> > +       return 0;
> > +}
> > +#endif
> > +
> > +static SIMPLE_DEV_PM_OPS(ds1307_pm_ops, ds1307_suspend, ds1307_resume);
> > +
> >  static struct i2c_driver ds1307_driver = {
> >         .driver = {
> >                 .name   = "rtc-ds1307",
> >                 .of_match_table = of_match_ptr(ds1307_of_match),
> >                 .acpi_match_table = ACPI_PTR(ds1307_acpi_ids),
> > +               .pm     = &ds1307_pm_ops,
> >         },
> >         .probe          = ds1307_probe,
> >         .id_table       = ds1307_id,
> > --
> > 2.9.3
> >
> 
> A gentle ping, any comments on this?
> 

It was rejected following the discussion you had with Heiner and your
email of the 25/08.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com