linux-kernel - Re: [PATCH 1/2] bdisp: Fix a possible sleep-in-atomic bug in bdisp_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27ce28d5-4e1e-f83e-f413-b297bbc1a2cc@xs4all.nl>
Date:   Fri, 15 Dec 2017 15:16:42 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     fabien.dessenne@...com,
        Benjamin Gaignard <benjamin.gaignard@...com>
Cc:     Jia-Ju Bai <baijiaju1990@...il.com>, mchehab@...nel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] bdisp: Fix a possible sleep-in-atomic bug in
 bdisp_hw_reset

Fabien or Benjamin, can you take a look at these two patches?

I'm a bit hesitant applying this since e.g. this bdisp_hw_reset() function might wait
for up to a second, which is a mite long for an interrupt :-)

Regards,

	Hans

On 12/12/17 14:47, Jia-Ju Bai wrote:
> The driver may sleep under a spinlock.
> The function call path is:
> bdisp_device_run (acquire the spinlock)
>   bdisp_hw_reset
>     msleep --> may sleep
> 
> To fix it, msleep is replaced with mdelay.
> 
> This bug is found by my static analysis tool(DSAC) and checked by my code review.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>
> ---
>  drivers/media/platform/sti/bdisp/bdisp-hw.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/sti/bdisp/bdisp-hw.c b/drivers/media/platform/sti/bdisp/bdisp-hw.c
> index b7892f3..4b62ceb 100644
> --- a/drivers/media/platform/sti/bdisp/bdisp-hw.c
> +++ b/drivers/media/platform/sti/bdisp/bdisp-hw.c
> @@ -382,7 +382,7 @@ int bdisp_hw_reset(struct bdisp_dev *bdisp)
>  	for (i = 0; i < POLL_RST_MAX; i++) {
>  		if (readl(bdisp->regs + BLT_STA1) & BLT_STA1_IDLE)
>  			break;
> -		msleep(POLL_RST_DELAY_MS);
> +		mdelay(POLL_RST_DELAY_MS);
>  	}
>  	if (i == POLL_RST_MAX)
>  		dev_err(bdisp->dev, "Reset timeout\n");
>