linux-kernel - [PATCH] FS: EXT4: syn error in __ext4_grp_locked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1513305136-27652-1-git-send-email-zhouzhouyi@gmail.com>
Date:   Fri, 15 Dec 2017 02:32:16 +0000
From:   zhouzhouyi@...il.com
To:     tytso@....edu, adilger.kernel@...ger.ca,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Zhouyi Zhou <zhouzhouyi@...il.com>
Subject: [PATCH] FS: EXT4: syn error in __ext4_grp_locked_error

From: Zhouyi Zhou <zhouzhouyi@...il.com>

In function __ext4_grp_locked_error,   __save_error_info
is called to save error info in super block block, but does not sync
that information to disk to info the subsequence fsck after reboot.

This patch sync the error information to disk. After this patch,
I think there is no obvious EXT4 error handle branche which leads to
"Remounting filesystem read-only" will leave the disk partition miss
the subsequence fsck.

Compiled in x86_64 Linux
Signed-off-by: Zhouyi Zhou <zhouzhouyi@...il.com>
---
 fs/ext4/super.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 7c46693..7159438 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -742,6 +742,7 @@ __acquires(bitlock)
 	}

 	ext4_unlock_group(sb, grp);
+	ext4_commit_super(sb, 1);
 	ext4_handle_error(sb);
 	/*
 	 * We only get here in the ERRORS_RO case; relocking the group
-- 
2.1.4