linux-kernel - [PATCH] mfd: cros_ec: register shutdown function for debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20171216080715.216702-1-bleung@chromium.org>
Date:   Sat, 16 Dec 2017 00:07:15 -0800
From:   Benson Leung <bleung@...omium.org>
To:     hywu@...gle.com, lee.jones@...aro.org, linux-kernel@...r.kernel.org
Cc:     hywu@...omium.org, bleung@...omium.org, bleung@...gle.com,
        Thierry Escande <thierry.escande@...labora.com>
Subject: [PATCH] mfd: cros_ec: register shutdown function for debugfs

From: Daniel Hung-yu Wu <hywu@...gle.com>

Reboot or shutdown during delayed works could corrupt communication with
EC and certain I2C controller may not be able to recover from the error
state.

This patch registers a shutdown callback used to cancel the debugfs log
worker thread.

Signed-off-by: Daniel Hung-yu Wu <hywu@...omium.org>
Signed-off-by: Thierry Escande <thierry.escande@...labora.com>
[resent this patch after rename of this file from platform/chrome to
 mfd]
Signed-off-by: Benson Leung <bleung@...omium.org>
---
 drivers/mfd/cros_ec_dev.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index e4fafdd96e5e..065666182ba2 100644
--- a/drivers/mfd/cros_ec_dev.c
+++ b/drivers/mfd/cros_ec_dev.c
@@ -461,6 +461,14 @@ static int ec_device_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static void ec_device_shutdown(struct platform_device *pdev)
+{
+	struct cros_ec_dev *ec = dev_get_drvdata(&pdev->dev);
+
+	/* Be sure to clear up debugfs delayed works */
+	cros_ec_debugfs_remove(ec);
+}
+
 static const struct platform_device_id cros_ec_id[] = {
 	{ DRV_NAME, 0 },
 	{ /* sentinel */ },
@@ -499,6 +507,7 @@ static struct platform_driver cros_ec_dev_driver = {
 	},
 	.probe = ec_device_probe,
 	.remove = ec_device_remove,
+	.shutdown = ec_device_shutdown,
 };
 
 static int __init cros_ec_dev_init(void)
-- 
2.15.1.504.g5279b80103-goog