linux-kernel - Re: [PATCH] ACPI, APEI, Fix use resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hA9QdAc1_Gwtu+hBGiH8nn84TS0Bwx0Ln4by6UpKDpSg@mail.gmail.com>
Date:   Sat, 16 Dec 2017 11:43:27 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Borislav Petkov <bp@...en8.de>,
        Vasyl Gomonovych <gomonovych@...il.com>
Cc:     Len Brown <lenb@...nel.org>, Tony Luck <tony.luck@...el.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI, APEI, Fix use resource_size

On Sat, Dec 16, 2017 at 11:34 AM, Rafael J. Wysocki <rafael@...nel.org> wrote:
> On Thu, Dec 14, 2017 at 10:37 AM, Borislav Petkov <bp@...en8.de> wrote:
>> On Thu, Dec 14, 2017 at 12:07:30AM +0100, Rafael J. Wysocki wrote:
>>> Which is exactly why you've got this question at all. ;-)
>>
>> So you're saying, you've got your minions to do review for you - you can
>> lay back and play all managerial now, huh?
>>
>> :-P
>>
>>> OK, let's queue it up for 4.16, then.
>>
>> Yeah, just keep an eye on reports of mapping errors...
>
> This appears to cause sparse to complain:
> drivers/acpi/apei/apei-base.c:509:21: sparse: incorrect type in
> argument 1 (different base types)
>
> It looks like that's a false-positive to me, though.

Ah, OK

It is not a false-positive.

The argument of resource_size() is (const struct resource *) and res
is of type (struct apei_res *).

I'm dropping this one.