linux-kernel - Re: [PATCH] x86: move parse_early_param to earlier code for add_efi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171216140632.462yk7pmlvpmz6if@gmail.com>
Date:   Sat, 16 Dec 2017 15:06:32 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Matt Fleming <matt@...eblueprint.co.uk>
Cc:     Dave Young <dyoung@...hat.com>, linux-kernel@...r.kernel.org,
        linux-efi@...r.kernel.org, ard.biesheuvel@...aro.org
Subject: Re: [PATCH] x86: move parse_early_param to earlier code for
 add_efi_memmap


* Matt Fleming <matt@...eblueprint.co.uk> wrote:

> >  	x86_init.oem.arch_setup();
> > @@ -962,6 +959,8 @@ void __init setup_arch(char **cmdline_p)
> >  
> >  	parse_early_param();
> >  
> > +	if (efi_enabled(EFI_BOOT))
> > +		efi_memblock_x86_reserve_range();
> >  #ifdef CONFIG_MEMORY_HOTPLUG
> >  	/*
> >  	 * Memory used by the kernel cannot be hot-removed because Linux
> > 
> 
> I prefer this version. Please re-send a full patch and update the
> subject line to include the "fix" somewhere; it wasn't obvious to me
> from the start that this is a bug fix.

Agreed.

I dropped the commit I just applied to tip:efi/core, since you are handling this, 
so this patch should come through the regular EFI channels, right?

Thanks,

	Ingo