linux-kernel - Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1513443676.29063.0.camel@linux.intel.com>
Date:   Sat, 16 Dec 2017 19:01:16 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Jason Gunthorpe <jgg@...pe.ca>
Cc:     Javier Martinez Canillas <javierm@...hat.com>,
        James Ettle <james@...le.org.uk>,
        linux-integrity@...r.kernel.org, azhar.shaikh@...el.com,
        linux-kernel@...r.kernel.org, james.l.morris@...cle.com
Subject: Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on
 Braswell system

On Fri, 2017-12-15 at 10:38 -0700, Jason Gunthorpe wrote:
> On Fri, Dec 15, 2017 at 04:56:30PM +0200, Jarkko Sakkinen wrote:
> > On Thu, Dec 14, 2017 at 12:10:52PM -0700, Jason Gunthorpe wrote:
> > > On Thu, Dec 14, 2017 at 08:08:58PM +0100, Javier Martinez Canillas wrote:
> > > 
> > > > Although probably reverting the offending commits is the right thing to do
> > > > until a proper solution is proposed.
> > > 
> > > Yes, if a fix is not forthcoming soon Jarkko should revert.
> > > 
> > 
> > I think I should drop the current patch going to 4.16 and revert the old
> > patch. Do we agree on this?
> 
> I think the entire is_bsw thing needs to go, clearly manipulating
> CLKRUN directly was not fully thought out?
> 
> Hopefully Intel will come up with a fix patch to preserve PS/2
> functionality and it won't come to a revert..

Agreed.

/Jarkko