linux-kernel - Re: [PATCH] lib/usercopy: fix sparse errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171217173124.GN21978@ZenIV.linux.org.uk>
Date:   Sun, 17 Dec 2017 17:31:24 +0000
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Luc Van Oostenryck <luc.vanoostenryck@...il.com>
Cc:     Christophe Leroy <christophe.leroy@....fr>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/usercopy: fix sparse errors

> The change is good.
> The commit message would better simply describe the problem instead
> of describing the symptom. For example, something like:
> 	The function _copy_to_user() is used to copy to address space.
> 	As such, the destination pointer should be annotated with
> 	'__user'.
> 	However, the function has the annotation wrongly, on the
> 	source instead of the destination (copy & paste error?).
> 	Fix this by moving the __user annotation to the correct
> 	argument.

FWIW, I've committed it with 

Fix misannotated out-of-line _copy_to_user()

Destination is a kernel pointer and source - a userland one
is _copy_from_user(); _copy_to_user() is the other way round.