linux-kernel - Re: pxa3xx_nand times out in 4.14 with JFFS2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171217222611.59f9031b@bbrezillon>
Date:   Sun, 17 Dec 2017 22:26:11 +0100
From:   Boris Brezillon <boris.brezillon@...e-electrons.com>
To:     Willy Tarreau <w@....eu>
Cc:     Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Miquel Raynal <miquel.raynal@...e-electrons.com>
Subject: Re: pxa3xx_nand times out in 4.14 with JFFS2

+Miquel

On Sun, 17 Dec 2017 22:16:50 +0100
Willy Tarreau <w@....eu> wrote:

> On Sun, Dec 17, 2017 at 06:01:29PM -0300, Ezequiel Garcia wrote:
> > On 17 December 2017 at 16:00, Willy Tarreau <w@....eu> wrote:  
> > > On Sun, Dec 17, 2017 at 07:07:46PM +0100, Boris Brezillon wrote:  
> > >> > > This would guarantee that devices with factory bad blocks,
> > >> > > (and no BBT), would be OK with this patch.  
> > >> >
> > >> > I see. I'm fine with trying provided I have reasonably good assurance
> > >> > that I won't have to go through the kwboot pain again :-/  
> > >>
> > >> There's a easy test you can do without scrubing the NAND:
> > >> 1/ comment the nand-on-flash-bbt property in your DT (this will trigger
> > >>    a full scan)
> > >> 2/ from u-boot (before booting the kernel), erase a block that you know
> > >>    contains nothing important
> > >> 3/ during the kernel scan, make sure this block is not reported as bad  
> > >
> > > OK so I tried and never faced any error. Thus I also attempted to mark
> > > a bad block in u-boot, it appeared in the bad blocks table, then I had
> > > to scrub the whole table to get rid of it. Each time when I booted I
> > > saw the message "Scanning device for bad blocks" but no error ever
> > > happened. So I hope it's OK.
> > >  
> > 
> > Nice. Thanks a lot Willy. I think this acks Boris' patch.  
> 
> You're welcome, you and Boris fixed my problem very quickly allowing me
> to continue to prepare my new router :-)
> 
> BTW, Boris please don't forget to mark your fix for -stable.

Actually, if things go well it will only be applied to stable
releases (I really hope we'll be able to switch to Miquel's driver in
4.16). BTW, if you have some time, maybe you can test Miquel's [1]
branch and let us know if it still works properly.

Thanks,

Boris

[1]https://github.com/miquelraynal/linux/tree/marvell/nand-next/nfc