linux-kernel - Re: [PATCH 1/1] drivers: android: Cleanup warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171217082221.GA4253@kroah.com>
Date:   Sun, 17 Dec 2017 09:22:21 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Harsh Shandilya <msfjarvis@...il.com>
Cc:     devel@...verdev.osuosl.org, Todd Kjos <tkjos@...roid.com>,
        linux-kernel@...r.kernel.org, Martijn Coenen <maco@...roid.com>
Subject: Re: [PATCH 1/1] drivers: android: Cleanup warnings

On Sun, Dec 17, 2017 at 03:07:55AM +0530, Harsh Shandilya wrote:
> Ran checkpatch across the entire drivers/android
> directory and fixed all relevant warnings. Summary
> of changes done:
> 
>  -> Convert all symbolic permissions into their
>     octal equivalents.
>  -> Use "%s", __func__ in logging macros where the
>     function name was previously hard-coded.
>  -> Add a blank line to separate declarations from
>     statements according to the kernel coding style
>     guidelines.
>  -> Fix linelength issues wherever possible.
>  -> Fix-up a commented out statement to use // in place
>     of /* */ to silence checkpatch.
> 
> Most line-length warnings were ignored in favor
> of code readability.
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Todd Kjos <tkjos@...roid.com>
> Cc: Martijn Coenen <maco@...roid.com>
> Cc: devel@...verdev.osuosl.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Harsh Shandilya <msfjarvis@...il.com>
> ---

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot