lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Sun, 17 Dec 2017 16:41:37 +0530
From:   Pravin Shedge <pravin.shedge4linux@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     pravin.shedge4linux@...il.com
Subject: [PATCH 3/3] lib: cleanup dead code from lib/percpu_test.c

lib/percpu_test.c code allows to compile either as a loadable modules or
builtin into the kernel.

Current code returns -EAGAIN on successful termination from module_init.
Such a fail will directly unload the module and hence there is no scope
to execute percpu_test_exit on module_exit.

Signed-off-by: Pravin Shedge <pravin.shedge4linux@...il.com>
---
 lib/percpu_test.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/lib/percpu_test.c b/lib/percpu_test.c
index 0b5d14d..ea31adb 100644
--- a/lib/percpu_test.c
+++ b/lib/percpu_test.c
@@ -126,12 +126,7 @@ static int __init percpu_test_init(void)
 	return -EAGAIN;  /* Fail will directly unload the module */
 }
 
-static void __exit percpu_test_exit(void)
-{
-}
-
 module_init(percpu_test_init)
-module_exit(percpu_test_exit)
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Greg Thelen");
-- 
2.7.4

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ