linux-kernel - Re: [PATCH v2] arm: kirkwood: dts: Use lower case for bindings notation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871sjshtmj.fsf@free-electrons.com>
Date:   Mon, 18 Dec 2017 17:45:56 +0100
From:   Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     Andrew Lunn <andrew@...n.ch>, Rob Herring <robh+dt@...nel.org>,
        Jason Cooper <jason@...edaemon.net>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arm: kirkwood: dts: Use lower case for bindings notation

Hi Mathieu,
 
 On ven., déc. 15 2017, Andrew Lunn <andrew@...n.ch> wrote:

> On Fri, Dec 15, 2017 at 06:07:11PM +0100, Mathieu Malaterre wrote:
>> Improve the DTS files using lower case to fix the following dtc warnings:
>> 
>> Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"
>> 
>> Converted using the following command:
>> 
>> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C
>> 
>> For simplicity, two sed expressions were used to solve each warnings separately.
>> 
>> To make the regex expression more robust a few other issues were resolved,
>> namely setting unit-address to lower case, and adding a whitespace before the
>> the opening curly brace:
>> 
>> https://elinux.org/Device_Tree_Linux#Linux_conventions
>> 
>> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")
>> 
>> Reported-by: David Daney <ddaney@...iumnetworks.com>
>> Suggested-by: Rob Herring <robh@...nel.org>
>> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
>
> Thanks for fixing up the commit message.
>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Applied on mvebu/dt

Thanks,

Gregory

>
>     Andrew

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com