linux-kernel - Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C925e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4B8F85D4-C35F-4B36-8196-5F51DA24422F@canonical.com>
Date:   Tue, 19 Dec 2017 02:07:46 +0800
From:   Kai-Heng Feng <kai.heng.feng@...onical.com>
To:     Dmitry Fleytman <dmitry.fleytman@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Alan Stern <stern@...land.harvard.edu>,
        Dmitry Fleytman <dmitry@...nix.com>,
        Lukáš Lalinský <lukas@...gene.sk>,
        Daniel Drake <drake@...lessm.com>,
        Samuel Thibault <samuel.thibault@...-lyon.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C925e

Hi, 

> On 19 Dec 2017, at 12:04 AM, Dmitry Fleytman <dmitry.fleytman@...il.com> wrote:
> 
> From: Dmitry Fleytman Dmitry Fleytman <dmitry.fleytman@...il.com>
> 
> Commit e0429362ab15
> ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e")
> introduced quirk to workaround an issue with some Logitech webcams.
> 
> There is one more model that has the same issue - C925e, so applying
> the same quirk as well.
> 
> See aforementioned commit message for detailed explanation of the problem.
> 
> Signed-off-by: Dmitry Fleytman <dmitry.fleytman@...il.com>
> ---
> drivers/usb/core/quirks.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index a10b346b9777..6d2d3b0bcc2a 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -52,10 +52,11 @@ static const struct usb_device_id usb_quirk_list[] = {
> 	/* Microsoft LifeCam-VX700 v2.0 */
> 	{ USB_DEVICE(0x045e, 0x0770), .driver_info = USB_QUIRK_RESET_RESUME },
> 
> -	/* Logitech HD Pro Webcams C920, C920-C and C930e */
> +	/* Logitech HD Pro Webcams C920, C920-C, C925e and C930e */
> 	{ USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT },
> 	{ USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
> 	{ USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT },
> +	{ USB_DEVICE(0x046d, 0x085B), .driver_info = USB_QUIRK_DELAY_INIT },

Nitpicking here, but maybe use 0x085b instead of 0x085B?

Kai-Heng

> 
> 	/* Logitech ConferenceCam CC3000e */
> 	{ USB_DEVICE(0x046d, 0x0847), .driver_info = USB_QUIRK_DELAY_INIT },
> -- 
> 2.14.1
>