linux-kernel - Re: [PATCH] net: qcom/emac: Change the order of mac up and sgmii open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171218.132209.907707924433000658.davem@davemloft.net>
Date:   Mon, 18 Dec 2017 13:22:09 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     hpuranik@...eaurora.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        timur@...eaurora.org
Subject: Re: [PATCH] net: qcom/emac: Change the order of mac up and sgmii
 open

From: Hemanth Puranik <hpuranik@...eaurora.org>
Date: Mon, 18 Dec 2017 11:27:47 +0530

> This patch fixes the order of mac_up and sgmii_open for the
> reasons noted below:
> 
> - If open takes more time(if the SGMII block is not responding or
>   if we want to do some delay based task) in this situation we
>   will hit NETDEV watchdog
> - The main reason : We should signal to upper layers that we are
>   ready to receive packets "only" when the entire path is initialized
>   not the other way around, this is followed in the reset path where
>   we do mac_down, sgmii_reset and mac_up. This also makes the driver
>   uniform across the reset and open paths.
> - In the future there may be need for delay based tasks to be done in
>   sgmii open which will result in NETDEV watchdog
> - As per the documentation the order of init should be sgmii, mac, rings
>   and DMA
> 
> Signed-off-by: Hemanth Puranik <hpuranik@...eaurora.org>

Applied.