linux-kernel - Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lghzc1vs.fsf@miraculix.mork.no>
Date:   Mon, 18 Dec 2017 19:44:07 +0100
From:   Bjørn Mork <bjorn@...k.no>
To:     SZ Lin <sz.lin@...a.com>
Cc:     Johan Hovold <johan@...nel.org>, Taiyi Wu <taiyity.wu@...a.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5

Johan Hovold <johan@...nel.org> writes:

>> +static const struct option_blacklist_info yuga_clm920_nc5_blacklist = {
>> +	.reserved = BIT(0) | BIT(1) | BIT(4),
>> +};
>
> Do you really need to blacklist the first interface?

Good question. Interface #0 does look a lot like a Qualcomm DM/DIAG
function, based on two bulk endpoints, no additional descriptors and the
fact that it is the first interface.  If so, then we do want a serial
driver for it.  There is a basic libqcdm implementation in ModemManager
if you want to test it out.

And I expect interface #4 is QMI/rmnet?  Feel free to confirm that
assumption with a patch against qmi_wwan :-)

Bjørn