linux-kernel - Re: [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171218191800.GE18894@mtr-leonro.local>
Date:   Mon, 18 Dec 2017 21:18:00 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Knut Omang <knut.omang@...cle.com>, linux-kernel@...r.kernel.org,
        Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org,
        Doug Ledford <dledford@...hat.com>,
        Håkon Bugge <haakon.bugge@...cle.com>,
        Åsmund Østvold <asmund.ostvold@...cle.com>
Subject: Re: [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for
 drivers/infiniband/core

On Mon, Dec 18, 2017 at 11:03:51AM -0800, Joe Perches wrote:
> On Mon, 2017-12-18 at 13:36 +0100, Knut Omang wrote:
> > On Mon, 2017-12-18 at 10:02 +0200, Leon Romanovsky wrote:
> []
> > > Also, I agree with other reviewers, there is no excuse for adding
> > > checkpatch specifics per-subsystem/folder, the differences are better
> > > to be treated in checkpatch.pl itself.
>
> What other reviewers are those?

I saw responses from Stephen and Jason.

>
> As a checkpatch maintainer, I don't believe it's appropriate
> to add many per-subsystem specific rules to checkpatch.

There are not so much differences, I'm aware of only one specific subsystem - netdev.
The rest of the kernel more or less follows general CodingStyle and
don't need anything specific in checkpatch.pl

Thanks

>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)