linux-kernel - Re: [PATCH] mm: don't use the same value for MAP_FIXED_SAFE and MAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171218204052.GR16951@dhcp22.suse.cz>
Date:   Mon, 18 Dec 2017 21:41:25 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Andrei Vagin <avagin@...nvz.org>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org
Subject: Re: [PATCH] mm: don't use the same value for MAP_FIXED_SAFE and
 MAP_SYNC

On Mon 18-12-17 10:49:16, Andrei Vagin wrote:
> Cc: Michal Hocko <mhocko@...nel.org>
> Fixes: ("fs, elf: drop MAP_FIXED usage from elf_map")
> Signed-off-by: Andrei Vagin <avagin@...nvz.org>
> ---
>  include/uapi/asm-generic/mman-common.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/include/uapi/asm-generic/mman-common.h b/include/uapi/asm-generic/mman-common.h
> index b37502cbbef7..2db3fa287274 100644
> --- a/include/uapi/asm-generic/mman-common.h
> +++ b/include/uapi/asm-generic/mman-common.h
> @@ -26,7 +26,9 @@
>  #else
>  # define MAP_UNINITIALIZED 0x0		/* Don't support this flag */
>  #endif
> -#define MAP_FIXED_SAFE	0x80000		/* MAP_FIXED which doesn't unmap underlying mapping */
> +
> +/* 0x0100 - 0x80000 flags are defined in asm-generic/mman.h */
> +#define MAP_FIXED_SAFE	0x100000		/* MAP_FIXED which doesn't unmap underlying mapping */

Ouch, I was developing on top of mmotm which didn't have the new the new
MAP_SYNC. Thanks for catching that. Andrew, could you fold this into the
patch, please?
-- 
Michal Hocko
SUSE Labs