linux-kernel - Re: [PATCH v2 10/19] ARM: dts: aspeed: Add LPC Snoop device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5ef27de-34c1-f5e9-e4ae-e2709b004677@kaod.org>
Date:   Mon, 18 Dec 2017 10:16:19 +0100
From:   Cédric Le Goater <clg@...d.org>
To:     Joel Stanley <joel@....id.au>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Andrew Jeffery <andrew@...id.au>,
        Patrick Venture <venture@...gle.com>, Xo Wang <xow@...gle.com>,
        Lei YU <mine260309@...il.com>
Cc:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Jeremy Kerr <jk@...abs.org>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-aspeed@...ts.ozlabs.org
Subject: Re: [PATCH v2 10/19] ARM: dts: aspeed: Add LPC Snoop device

On 12/15/2017 07:24 AM, Joel Stanley wrote:
> LPC snoop hardware on the ASPEED BMC, used for monitoring
> host I/O port activity.
> 
> Signed-off-by: Joel Stanley <joel@....id.au>
> ---
>  arch/arm/boot/dts/aspeed-g4.dtsi | 7 +++++++
>  arch/arm/boot/dts/aspeed-g5.dtsi | 6 ++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> index f6fee40c04c0..b3580f37f507 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -236,6 +236,13 @@
>  						status = "disabled";
>  					};
>  
> +					lpc_snoop: lpc-snoop@0 {
> +						compatible = "aspeed,ast2500-lpc-snoop";

it should be :

	aspeed,ast2400-lpc-snoop

a part from that :

Reviewed-by: Cédric Le Goater <clg@...d.org>

> +						reg = <0x0 0x80>;
> +						interrupts = <8>;
> +						status = "disabled";
> +					};
> +
>  					lhc: lhc@20 {
>  						compatible = "aspeed,ast2500-lhc";
>  						reg = <0x20 0x24 0x48 0x8>;
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index 96a9d2fe3f0d..50766f0629f8 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -287,6 +287,12 @@
>  						status = "disabled";
>  					};
>  
> +					lpc_snoop: lpc-snoop@0 {
> +						compatible = "aspeed,ast2500-lpc-snoop";
> +						reg = <0x0 0x80>;
> +						interrupts = <8>;
> +						status = "disabled";
> +					};
>  
>  					lhc: lhc@20 {
>  						compatible = "aspeed,ast2500-lhc";
>