linux-kernel - Re: [PATCH] Pass the task_struct explicitly to delayacct_blkio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171218113426.vndsy2m5qhxrkesg@hirez.programming.kicks-ass.net>
Date:   Mon, 18 Dec 2017 12:34:26 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Josh Snyder <joshs@...flix.com>
Cc:     linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
        Brendan Gregg <bgregg@...flix.com>,
        linux-block@...r.kernel.org, Tejun Heo <tj@...nel.org>,
        Balbir Singh <bsingharora@...il.com>,
        Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH] Pass the task_struct explicitly to delayacct_blkio_end

On Fri, Dec 15, 2017 at 06:11:43PM +0000, Josh Snyder wrote:

> Subject: [PATCH] Pass the task_struct explicitly to delayacct_blkio_end

That subject is crap; it needs a subsystem prefix and it needs to
describe what is done, not how its done.

Something like:

  delayacct: Fix double accounting for blk-io

> Before e33a9bba85a8, delayacct_blkio_end was called after
> context-switching into the task which completed I/O. This resulted in
> double counting: the task would account a delay both waiting for I/O and
> for time spent in the runqueue.
> 
> With e33a9bba85a8, delayacct_blkio_end is called by try_to_wake_up. In
> ttwu, we have not yet context-switched. This is more correct, in that the
> delay accounting ends when the I/O is complete. But delayacct_blkio_end
> relies upon `get_current()`, and we have not yet context-switched into the
> task whose I/O completed. This results in the wrong task having its delay
> accounting statistics updated.

The correct way to quote a commit is like:

  e33a9bba85a8 ("sched/core: move IO scheduling accounting from io_schedule_timeout() into scheduler")

> Instead of doing that, pass the task_struct being woken to
> delayacct_blkio_end, so that it can update the statistics of the correct
> task_struct.