linux-kernel - Re: [PATCH v2] ASOC: wm8960: Add multiple MCLK frequency support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20171218115526.z336fwohv5mt45sk@localhost.localdomain>
Date:   Mon, 18 Dec 2017 11:55:26 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     chen liu <chen.liu.opensource@...il.com>
CC:     Liam Girdwood <lgirdwood@...il.com>, <broonie@...nel.org>,
        <perex@...ex.cz>, <tiwai@...e.com>, <shengjiu.wang@...escale.com>,
        <linux-kernel@...r.kernel.org>, <daniel.baluta@....com>,
        <patches@...nsource.wolfsonmicro.com>,
        <alsa-devel@...a-project.org>
Subject: Re: [PATCH v2] ASOC: wm8960: Add multiple MCLK frequency support

On Mon, Dec 18, 2017 at 07:32:41PM +0800, chen liu wrote:
> 2017-12-18 17:31 GMT+08:00 Charles Keepax <ckeepax@...nsource.cirrus.com>:
> 
> > On Fri, Dec 15, 2017 at 09:07:15PM +0800, chen liu wrote:
> > > 2017-12-15 0:19 GMT+08:00 Charles Keepax <ckeepax@...nsource.cirrus.com
> > >:
> > > > On Wed, Dec 13, 2017 at 08:37:30PM +0800, Chen.Liu wrote:
> According to your detailed description above, I understand what you mean.
> For the 'wm8960_configure_pll' function,it deduces a reasonable PLL output
> clock frequency based on the 'freq_in' frequency,the sample rate,and the bit
> clock.
> 
> static int wm8960_configure_clocking(struct snd_soc_codec*codec)
> ...
>         freq_out = wm8960_configure_pll(codec, freq_in, &i, &j, &k);
>         if (freq_out < 0) {
>                 dev_err(codec->dev, "failed to configure clock via PLL\n");
>                 return freq_out;
>         }
>         wm8960_set_pll(codec, freq_in, freq_out);
> ...
> 
> In the 'wm8960_configure_clocking' function, it sets the PLL divider by
> calling
> the 'wm8960_set_pll' function after calling the 'wm8960_configure_pll'.
> However,there is no support for SYSCLK_DIV = 2 in the 'wm8960_set_pll'
> function.
> 
> Looking forward to your reply.

Indeed yes, as it looks like the intention was you would set the
SYSCLKDIV manually if setting the PLL manually. But why not just
call wm8960_set_pll will WM8960_SYSCLK_AUTO, and then your code
will use the configure_pll stuff?

I would like to understand what about that approach isn't working
for you as that seems like the easiest solution.

Thanks,
Charles