linux-kernel - Re: [patch V163 03/51] x86/vsyscall/64: Warn and fail vsyscall emulation in NATIVE mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171218144448.n5mj2hk54ujtvvv4@pd.tnic>
Date:   Mon, 18 Dec 2017 15:44:48 +0100
From:   Borislav Petkov <bp@...e.de>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Andy Lutomirsky <luto@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Dave Hansen <dave.hansen@...el.com>,
        Greg KH <gregkh@...uxfoundation.org>, keescook@...gle.com,
        hughd@...gle.com, Brian Gerst <brgerst@...il.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Denys Vlasenko <dvlasenk@...hat.com>,
        Rik van Riel <riel@...hat.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>,
        David Laight <David.Laight@...lab.com>,
        Eduardo Valentin <eduval@...zon.com>, aliguori@...zon.com,
        Will Deacon <will.deacon@....com>, daniel.gruss@...k.tugraz.at,
        Ingo Molnar <mingo@...nel.org>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [patch V163 03/51] x86/vsyscall/64: Warn and fail vsyscall
 emulation in NATIVE mode

On Mon, Dec 18, 2017 at 12:42:18PM +0100, Thomas Gleixner wrote:
> From: Andy Lutomirski <luto@...nel.org>
> 
> If something goes wrong with pagetable setup, vsyscall=native will
> accidentally fall back to emulation.  Make it warn and fail so that we
> notice.
> 
> Signed-off-by: Andy Lutomirski <luto@...nel.org>
> Signed-off-by: Ingo Molnar <mingo@...nel.org>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Brian Gerst <brgerst@...il.com>
> Cc: David Laight <David.Laight@...lab.com>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> ---
>  arch/x86/entry/vsyscall/vsyscall_64.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> --- a/arch/x86/entry/vsyscall/vsyscall_64.c
> +++ b/arch/x86/entry/vsyscall/vsyscall_64.c
> @@ -138,6 +138,10 @@ bool emulate_vsyscall(struct pt_regs *re
>  
>  	WARN_ON_ONCE(address != regs->ip);
>  
> +	/* This should be unreachable in NATIVE mode. */
> +	if (WARN_ON(vsyscall_mode == NATIVE))
> +		return false;

There's this nice warn_bad_vsyscall() thing. Why not use that?

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--