linux-kernel - Re: [PATCH for-4.15] wireless: create, don't append, to shipped-certs.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Dec 2017 21:11:30 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Brian Norris <briannorris@...omium.org>
Cc:     linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
        Paul Menzel <pmenzel+linux-wireless@...gen.mpg.de>,
        Damian Tometzki <damian.tometzki@...oud.com>
Subject: Re: [PATCH for-4.15] wireless: create, don't append, to
 shipped-certs.c

On Tue, 2017-12-19 at 11:23 -0800, Brian Norris wrote:
> 
> In practice, this is seen often by having a separate source and build
> directory, where the build artifacts remain but the source tree changes
> (even if Seth's cert doesn't change, it might get created/removed when
> checking out different source revisions).
> 
> I don't see why this rule should be an append; we're writing the file
> all in one go.

Yeah, that was an oversight from the code prior to my changes to make
it write it only once.

> Fixes: 90a53e4432b1 ("cfg80211: implement regdb signature checking")
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> ---
> This is an error introduced in 4.15-rc1.
> 
> I've seen other errors reported by Paul and Damian (CC'd); I think Paul's
> failure was fixed already, but Damian might have still been having problems
> with not having a "clean" environment. Perhaps he was hitting this bug?

I'm not really sure what that problem was - I think a combination of
missing clean-files and this perhaps? Anyway, I applied another fix for
this today, and it's on the way to Linus's tree, along with the missing
clean-files and a conversion to non-binary files so that patches work
better.

johannes