linux-kernel - Re: [PATCH] bpf: fix BPF_KPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171219231108.sbks4djkk4cdt3cv@ast-mbp>
Date:   Tue, 19 Dec 2017 15:11:10 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Josef Bacik <jbacik@...com>, linux-kernel@...r.kernel.org,
        Daniel Borkmann <daniel@...earbox.net>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] bpf: fix BPF_KPROBE_OVERRIDE dependencies

On Tue, Dec 19, 2017 at 11:12:04AM +0100, Arnd Bergmann wrote:
> CONFIG_BPF_KPROBE_OVERRIDE causes a link failure when CONFIG_KPROBE_EVENTS
> is disabled:
> 
> kernel/trace/bpf_trace.o: In function `bpf_override_return':
> (.text+0x172): undefined reference to `bpf_kprobe_override'
> 
> This adds it to the list of dependencies.
> 
> Fixes: 9802d86585db ("bpf: add a bpf_override_function helper")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

lgtm.
Could you please resubmit it to netdev targeting bpf-next tree?

Thanks!

> ---
>  kernel/trace/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index ace4547b7564..0d83668652ef 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -534,6 +534,7 @@ config FUNCTION_PROFILER
>  config BPF_KPROBE_OVERRIDE
>  	bool "Enable BPF programs to override a kprobed function"
>  	depends on BPF_EVENTS
> +	depends on KPROBE_EVENTS
>  	depends on KPROBES_ON_FTRACE
>  	depends on HAVE_KPROBE_OVERRIDE
>  	depends on DYNAMIC_FTRACE_WITH_REGS
> -- 
> 2.9.0
>