lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <BM1PR01MB050053D9786A230A2D79F757E60F0@BM1PR01MB0500.INDPRD01.PROD.OUTLOOK.COM> Date: Tue, 19 Dec 2017 05:18:42 +0000 From: Dhaval Shah <dhaval.shah@...tnautics.com> To: Greg KH <gregkh@...uxfoundation.org> CC: "arnd@...db.de" <arnd@...db.de>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 3/3] misc: ad525x_dpot: macros should not use a trailing semicolon Hi Greg k-h, ________________________________________ > From: Greg KH <gregkh@...uxfoundation.org> > Sent: Monday, December 18, 2017 8:32 PM > To: Dhaval Shah > Cc: arnd@...db.de; linux-kernel@...r.kernel.org > Subject: Re: [PATCH 3/3] misc: ad525x_dpot: macros should not use a trailing semicolon > > On Fri, Dec 08, 2017 at 01:43:05PM +0530, Dhaval Shah wrote: > > Resolved all the macros should not use a trailing semicolon > > checkpatch warnings. Issue found by checkpatch. > > > > Signed-off-by: Dhaval Shah <dhaval.shah@...tnautics.com> > > --- > > drivers/misc/ad525x_dpot.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c > > index 577f5e76c8a8..bc591b7168db 100644 > > --- a/drivers/misc/ad525x_dpot.c > > +++ b/drivers/misc/ad525x_dpot.c > > @@ -515,11 +515,11 @@ set_##_name(struct device *dev, \ > > #define DPOT_DEVICE_SHOW_SET(name, reg) \ > > DPOT_DEVICE_SHOW(name, reg) \ > > DPOT_DEVICE_SET(name, reg) \ > > -static DEVICE_ATTR(name, S_IWUSR | S_IRUGO, show_##name, set_##name); > > +static DEVICE_ATTR(name, S_IWUSR | S_IRUGO, show_##name, set_##name) > > This should be using DEVICE_ATTR_RW() instead of DEVICE_ATTR(), care to > fix that up in a follow-on patch for this driver? > Sure. I will update this change in follow-on patch for this driver once this patch set merged. Thanks, Dhaval > thanks, > > greg k-h
Powered by blists - more mailing lists