linux-kernel - RE: [Bug fix] octeon-i2c driver improvement [2/2]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR0702MB36156DA2F16D4794E1ED99B78E0F0@VI1PR0702MB3615.eurprd07.prod.outlook.com>
Date:   Tue, 19 Dec 2017 05:25:49 +0000
From:   "Zhang, Sean C. (NSB - CN/Hangzhou)" <sean.c.zhang@...ia-sbell.com>
To:     David Daney <ddaney@...iumnetworks.com>,
        Jan Glauber <jan.glauber@...iumnetworks.com>,
        "david.daney@...ium.com" <david.daney@...ium.com>
CC:     "wsa@...-dreams.de" <wsa@...-dreams.de>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [Bug fix] octeon-i2c driver improvement [2/2]

Hi Jan and David,

Any other comment for these three patches? I sent them separately.
1. [Bug fix] octeon-i2c driver updates
2. [Bug fix] octeon-i2c driver improvement [1/2]
3. [Bug fix] octeon-i2c driver improvement [2/2]

BR,
Sean Zhang

-----Original Message-----
From: Zhang, Sean C. (NSB - CN/Hangzhou) 
Sent: Wednesday, December 06, 2017 5:51 PM
To: 'David Daney' <ddaney@...iumnetworks.com>; 'Jan Glauber' <jan.glauber@...iumnetworks.com>; 'david.daney@...ium.com' <david.daney@...ium.com>
Cc: 'wsa@...-dreams.de' <wsa@...-dreams.de>; 'linux-i2c@...r.kernel.org' <linux-i2c@...r.kernel.org>; 'linux-kernel@...r.kernel.org' <linux-kernel@...r.kernel.org>
Subject: [Bug fix] octeon-i2c driver improvement [2/2]

Hi Jan and David,

For octeon-i2c driver, there has duplicated interrupt disable in octeon_i2c_isr(),
octeon_i2c_hlc_wait() and octeon_i2c_wait(), since octeon_i2c_hlc_wait() and
octeon_i2c_wait() has pair of interrupt enable and disable, so the interrupt disable in octeon_i2c_isr() is not necessary. attached patch removed this unnecessary interrupt disable step.

Please have time to review it. Thanks.

BR
Sean Zhang