linux-kernel - Re: [PATCH v.2] 4.15 vmgfx boot warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Dec 2017 19:26:03 -0500
From:   Woody Suwalski <terraluna977@...il.com>
To:     Daniel Vetter <daniel.vetter@...el.com>
Cc:     Sinclair Yeh <syeh@...are.com>,
        DRI mailing list <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Dave Airlie <airlied@...ux.ie>
Subject: Re: [PATCH v.2] 4.15 vmgfx boot warning

The 4.15 drm_atomic_helper driver shows a warning during boot (both 32 
and 64 bit x86)
It is caused by a mismatch between the result of vmw_enable_vblank() and 
what the drm_atomic_helper expects:
    /...
    ret = drm_crtc_vblank_get(crtc);
    WARN_ONCE(ret != -EINVAL, "driver forgot to call 
drm_crtc_vblank_off()\n");
    /...

Signed-off by: Woody Suwalski <terraluna977@...il.com>

--- a/drivers/gpu/drm/drm_atomic_helper.c    2017-12-16 
09:55:33.853374561 -0500
+++ b/drivers/gpu/drm/drm_atomic_helper.c    2017-12-16 
10:55:56.089090752 -0500
@@ -889,7 +889,7 @@ disable_outputs(struct drm_device *dev,
              continue;

          ret = drm_crtc_vblank_get(crtc);
-        WARN_ONCE(ret != -EINVAL, "driver forgot to call 
drm_crtc_vblank_off()\n");
+        WARN_ONCE((ret != -EINVAL && ret != -ENOSYS), "driver forgot to 
call drm_crtc_vblank_off()\n");
          if (ret == 0)
              drm_crtc_vblank_put(crtc);
      }


View attachment "040_drm_atomic_helper.patch" of type "text/x-patch" (499 bytes)