linux-kernel - Re: [PATCH v2 2/4] siox: add support for tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171219082823.GA12139@kroah.com>
Date:   Tue, 19 Dec 2017 09:28:23 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     linux-kernel@...r.kernel.org, kernel@...gutronix.de,
        Gavin Schenk <g.schenk@...elmann.de>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH v2 2/4] siox: add support for tracing

On Mon, Dec 18, 2017 at 05:59:08PM +0100, Uwe Kleine-König wrote:
> Implement tracing for SIOX. There are events for the data that is
> written to the bus and for data being read from it.
> 
> Acked-by: Gavin Schenk <g.schenk@...elmann.de>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
> 
> Notes:
>     Changes since v1, sent with Message-Id: 20171207093008.20688-3-u.kleine-koenig@...gutronix.de
>     
>      - drop a WARN_ON
>      - Added Steven Rostedt to Cc: now that the first patch is expected to stay
>        more or less as it is.
> 
>  drivers/siox/siox-core.c    | 12 +++++++++
>  include/trace/events/siox.h | 66 +++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 78 insertions(+)
>  create mode 100644 include/trace/events/siox.h

This patch gives me the following build warnings:

  CC [M]  drivers/siox/siox-core.o
In file included from ./include/trace/define_trace.h:96:0,
                 from ./include/trace/events/siox.h:66,
                 from drivers/siox/siox-core.c:37:
./include/trace/events/siox.h: In function ‘trace_raw_output_siox_set_data’:
./include/trace/events/siox.h:27:16: warning: field width specifier ‘*’ expects argument of type ‘int’, but argument 5 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
      TP_printk("siox-%d-%u [%*phD]",
                ^
./include/trace/trace_events.h:360:22: note: in definition of macro ‘DECLARE_EVENT_CLASS’
  trace_seq_printf(s, print);     \
                      ^~~~~
./include/trace/trace_events.h:79:9: note: in expansion of macro ‘PARAMS’
         PARAMS(print));         \
         ^~~~~~
./include/trace/events/siox.h:9:1: note: in expansion of macro ‘TRACE_EVENT’
 TRACE_EVENT(siox_set_data,
 ^~~~~~~~~~~
./include/trace/events/siox.h:27:6: note: in expansion of macro ‘TP_printk’
      TP_printk("siox-%d-%u [%*phD]",
      ^~~~~~~~~
In file included from ./include/trace/trace_events.h:394:0,
                 from ./include/trace/define_trace.h:96,
                 from ./include/trace/events/siox.h:66,
                 from drivers/siox/siox-core.c:37:
./include/trace/events/siox.h:27:30: note: format string is defined here
      TP_printk("siox-%d-%u [%*phD]",
                             ~^~
In file included from ./include/trace/define_trace.h:96:0,
                 from ./include/trace/events/siox.h:66,
                 from drivers/siox/siox-core.c:37:
./include/trace/events/siox.h: In function ‘trace_raw_output_siox_get_data’:
./include/trace/events/siox.h:55:16: warning: field width specifier ‘*’ expects argument of type ‘int’, but argument 6 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
      TP_printk("siox-%d-%u (%02hhx) [%*phD]",
                ^
./include/trace/trace_events.h:360:22: note: in definition of macro ‘DECLARE_EVENT_CLASS’
  trace_seq_printf(s, print);     \
                      ^~~~~
./include/trace/trace_events.h:79:9: note: in expansion of macro ‘PARAMS’
         PARAMS(print));         \
         ^~~~~~
./include/trace/events/siox.h:34:1: note: in expansion of macro ‘TRACE_EVENT’
 TRACE_EVENT(siox_get_data,
 ^~~~~~~~~~~
./include/trace/events/siox.h:55:6: note: in expansion of macro ‘TP_printk’
      TP_printk("siox-%d-%u (%02hhx) [%*phD]",
      ^~~~~~~~~
In file included from ./include/trace/trace_events.h:394:0,
                 from ./include/trace/define_trace.h:96,
                 from ./include/trace/events/siox.h:66,
                 from drivers/siox/siox-core.c:37:
./include/trace/events/siox.h:55:39: note: format string is defined here
      TP_printk("siox-%d-%u (%02hhx) [%*phD]",
                                      ~^~


So I really can't take this as-is :(

I've applied the first patch to my tree now.

thanks,

greg k-h