linux-kernel - Re: [PATCH v3] tty: serial: meson: allow baud-rates lower than 9600

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171219085638.GA21577@kroah.com>
Date:   Tue, 19 Dec 2017 09:56:38 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Thomas Rohloff <v10lator@...ay.de>
Cc:     Jiri Slaby <jslaby@...e.com>, Carlo Caione <carlo@...one.org>,
        Kevin Hilman <khilman@...libre.com>,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] tty: serial: meson: allow baud-rates lower than 9600

On Sat, Nov 04, 2017 at 01:36:07PM +0100, Thomas Rohloff wrote:
> Devices like DCF77 receivers need the baud-rate to be as low as 50.
> 
> I have tested this on a Meson GXL device with uart_A.
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Jiri Slaby <jslaby@...e.com>
> Cc: Carlo Caione <carlo@...one.org>
> Cc: Kevin Hilman <khilman@...libre.com>
> Cc: linux-amlogic@...ts.infradead.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Thomas Rohloff <v10lator@...ay.de>
> ---
> drivers/tty/serial/meson_uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/meson_uart.c
> b/drivers/tty/serial/meson_uart.c
> index 07c0f98be3ac..e281ce5d101d 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -362,7 +362,7 @@ static void meson_uart_set_termios(struct uart_port
> *port,
> 
> 	writel(val, port->membase + AML_UART_CONTROL);
> 
> -	baud = uart_get_baud_rate(port, termios, old, 9600, 4000000);
> +	baud = uart_get_baud_rate(port, termios, old, 50, 4000000);
> 	meson_uart_change_speed(port, baud);
> 
> 	port->read_status_mask = AML_UART_TX_FIFO_WERR;

This patch is corrupted (line-wrapped), and can not be applied.  Please
fix up and resend.

thanks,

greg k-h