linux-kernel - Re: [Xen-devel] [PATCH v2] xen/balloon: Mark unallocated host memory as UNUSABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <5A38E9A502000078001985CF@prv-mh.provo.novell.com>
Date:   Tue, 19 Dec 2017 02:27:49 -0700
From:   "Jan Beulich" <JBeulich@...e.com>
To:     "Juergen Gross" <jgross@...e.com>
Cc:     <christian.koenig@....com>, <helgaas@...nel.org>,
        <xen-devel@...ts.xen.org>,
        "Boris Ostrovsky" <boris.ostrovsky@...cle.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH v2] xen/balloon: Mark unallocated host
 memory as UNUSABLE

>>> On 19.12.17 at 10:21, <jgross@...e.com> wrote:
> On 19/12/17 09:23, Jan Beulich wrote:
>>>>> On 18.12.17 at 23:22, <boris.ostrovsky@...cle.com> wrote:
>>> +void __init arch_xen_balloon_init(struct resource *hostmem_resource)
>>> +{
>>> +	struct xen_memory_map memmap;
>>> +	int rc;
>>> +	unsigned int i, last_guest_ram;
>>> +	phys_addr_t max_addr = max_pfn << PAGE_SHIFT;
>> 
>> PFN_PHYS() as right now you still have an issue on 32-bit.
> 
> Why? PFN_PHYS is defined as:
> 
> #define PFN_PHYS(x) ((phys_addr_t)(x) << PAGE_SHIFT)

Well, that's why I suggested its use (just like you did in your
own review). IOW - now I'm confused.

Jan