linux-kernel - Re: [PATCH TRIVIAL] PM / wakeup: only recommend "call"ing device_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2776612.L7VRzgYgOe@aspire.rjw.lan>
Date:   Tue, 19 Dec 2017 11:45:23 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Brian Norris <briannorris@...omium.org>
Cc:     Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH TRIVIAL] PM / wakeup: only recommend "call"ing device_init_wakeup() once

On Tuesday, December 19, 2017 12:30:48 AM CET Brian Norris wrote:
> I'll admit admit it: I've written bad driver code that tries to
> configure a device's wake IRQ without having called device_init_wakeup()
> first. But do you really have to ask ask me twice?
> 
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> ---
>  drivers/base/power/wakeup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c
> index 38559f04db2c..cb72965b3281 100644
> --- a/drivers/base/power/wakeup.c
> +++ b/drivers/base/power/wakeup.c
> @@ -298,7 +298,7 @@ int device_wakeup_attach_irq(struct device *dev,
>  
>  	ws = dev->power.wakeup;
>  	if (!ws) {
> -		dev_err(dev, "forgot to call call device_init_wakeup?\n");
> +		dev_err(dev, "forgot to call device_init_wakeup?\n");
>  		return -EINVAL;
>  	}
>  
> 

Applied, thanks!