linux-kernel - RE: [PATCH] phy: rcar: fix gen3-usb2 build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <TY1PR06MB0992FEBB528234E6A2B944AAD80F0@TY1PR06MB0992.apcprd06.prod.outlook.com>
Date:   Tue, 19 Dec 2017 11:51:24 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Wang Dongsheng <dongsheng.wang@...-semitech.com>,
        "kishon@...com" <kishon@...com>
CC:     "jh80.chung@...sung.com" <jh80.chung@...sung.com>,
        "krzk@...nel.org" <krzk@...nel.org>,
        "heiko@...ech.de" <heiko@...ech.de>,
        "vivek.gautam@...eaurora.org" <vivek.gautam@...eaurora.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] phy: rcar: fix gen3-usb2 build error

Hi Wang-san,

> From: Wang Dongsheng, Sent: Tuesday, December 19, 2017 8:37 PM
> 
> of_usb_get_dr_mode_by_phy is implemented in usb/common/common.c.
> So the PHY_RCAR_GEN3_USB2 must depend on USB_SUPPORT/USB_COMMON.
> 
>  LD      vmlinux.o
>  MODPOST vmlinux.o
> .../phy-rcar-gen3-usb2.o: In function `rcar_gen3_phy_usb2_probe':
> ...: undefined reference to `of_usb_get_dr_mode_by_phy'
> make: *** [vmlinux] Error 1
> 
> Signed-off-by: Wang Dongsheng <dongsheng.wang@...-semitech.com>

Thank you for the patch! However, Arnd already sent such a patch before [1]
and it will be merged into the usb repository [2] in near the future.

[1] https://lkml.org/lkml/2017/11/2/373
[2] git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-linus branch.

Best regards,
Yoshihiro Shimoda

> ---
>  drivers/phy/renesas/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/phy/renesas/Kconfig b/drivers/phy/renesas/Kconfig
> index cb09245..c845fac 100644
> --- a/drivers/phy/renesas/Kconfig
> +++ b/drivers/phy/renesas/Kconfig
> @@ -12,7 +12,9 @@ config PHY_RCAR_GEN3_USB2
>  	tristate "Renesas R-Car generation 3 USB 2.0 PHY driver"
>  	depends on ARCH_RENESAS
>  	depends on EXTCON
> +	depends on USB_SUPPORT
>  	select GENERIC_PHY
> +	select USB_COMMON
>  	help
>  	  Support for USB 2.0 PHY found on Renesas R-Car generation 3 SoCs.
> 
> --
> 2.7.4