linux-kernel - Re: [PATCH v6 1/3] lib: Add strongly typed 64bit int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKv63usxFaYET4odT6p07zhXxZ6qwxM6=d7+Ms6z04vjX3p3WQ@mail.gmail.com>
Date:   Tue, 19 Dec 2017 14:54:59 +0100
From:   Crt Mori <cmo@...exis.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Rusty Russell <rusty@...tcorp.com.au>,
        Ian Abbott <abbotti@....co.uk>,
        Larry Finger <Larry.Finger@...inger.net>,
        Niklas Soderlund <niklas.soderlund+renesas@...natech.se>,
        Thomas Gleixner <tglx@...utronix.de>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-kernel@...r.kernel.org, Linux Iio <linux-iio@...r.kernel.org>
Subject: Re: [PATCH v6 1/3] lib: Add strongly typed 64bit int_sqrt

On 19 December 2017 at 14:25, Peter Zijlstra <peterz@...radead.org> wrote:
> On Tue, Dec 19, 2017 at 10:31:18AM +0100, Crt Mori wrote:
>> IIO kernel does not have the recent version in, so thanks for heads
>
> IIO?
>

Industrial Input / Output Subsytem tree

>> up. It does not change much for my function.
>
> The comment says:
>
>  * Computes: floor(sqrt(x))
>
> floor(sqrt(2^64-1)) == 2^32-1
>

OK, so return value should be u32.