linux-kernel - RE: [PATCH] crypto: x86/twofish-3way

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4fecc01e8a14142a9add860aa2ec67a@AcuMS.aculab.com>
Date:   Tue, 19 Dec 2017 14:37:07 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Juergen Gross' <jgross@...e.com>, Ingo Molnar <mingo@...nel.org>,
        "Eric Biggers" <ebiggers3@...il.com>
CC:     "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        "Josh Poimboeuf" <jpoimboe@...hat.com>,
        Jussi Kivilinna <jussi.kivilinna@....fi>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "syzkaller-bugs@...glegroups.com" <syzkaller-bugs@...glegroups.com>,
        Eric Biggers <ebiggers@...gle.com>,
        "Peter Zijlstra" <a.p.zijlstra@...llo.nl>
Subject: RE: [PATCH] crypto: x86/twofish-3way - Fix %rbp usage

From: Juergen Gross
> Sent: 19 December 2017 08:05
..
> 
> Exchanging 2 registers can be done without memory access via:
> 
> xor reg1, reg2
> xor reg2, reg1
> xor reg1, reg2

That'll generate horrid data dependencies.
ISTR that there are some optimisations for the stack,
so even 'push reg1', 'mov reg2,reg1', 'pop reg2' might
be faster than the above.

	David