linux-kernel - Re: [PATCH 4.9 124/177] platform/x86: sony-laptop: Fix error handling in sony_nc_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171219014635.h3tqbs5adjiojdqq@sasha-lappy>
Date:   Tue, 19 Dec 2017 01:46:44 +0000
From:   alexander.levin@...izon.com
To:     Joe Perches <joe@...ches.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Markus Elfring <elfring@...rs.sourceforge.net>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH 4.9 124/177] platform/x86: sony-laptop: Fix error handling
 in sony_nc_setup_rfkill()

On Mon, Dec 18, 2017 at 09:21:51AM -0800, Joe Perches wrote:
>On Mon, 2017-12-18 at 16:49 +0100, Greg Kroah-Hartman wrote:
>> 4.9-stable review patch.  If anyone has any objections, please let me know.
>
>I am _very_ suspicious of any -stable patch by Markus Elfring.
>
>Are you sure this is necessary and useful for -stable?
>Does this actually fix something or does it merely reduce
>object size a few bytes?

Yeah... While the patch on it's own makes some sense, the code around
it is pretty crappy and doesn't benefit from the patch.

I'll drop it, thanks!

-- 

Thanks,
Sasha