linux-kernel - Re: [resend PATCH 0/2] fix VFS register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171219155707.GB2787@dhcp22.suse.cz>
Date:   Tue, 19 Dec 2017 16:57:07 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Al Viro <viro@...IV.linux.org.uk>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
        Aliaksei Karaliou <akaraliou.dev@...il.com>,
        linux-mm@...ck.org, linux-fsdevel@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [resend PATCH 0/2] fix VFS register_shrinker fixup

On Tue 19-12-17 15:34:19, Al Viro wrote:
> On Tue, Dec 19, 2017 at 04:19:15PM +0100, Michal Hocko wrote:
> > Dohh, I have missed resend by Tetsuo http://lkml.kernel.org/r/1513596701-4518-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp
> > (thanks for dropping me from the CC).  Al seeemed to take the patch. We
> > still need patch 2. Al, are you going to take it from this thread or you
> > are going to go your way?
> 
> Umm... git log for-linus in vfs.git since yesterday:

OK, thanks!

> commit 9ee332d99e4d5a97548943b81c54668450ce641b
> Author: Al Viro <viro@...iv.linux.org.uk>
> Date:   Mon Dec 18 15:05:07 2017 -0500
> 
>     sget(): handle failures of register_shrinker()
>     
>     Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> 
> commit bb422a738f6566f7439cd347d54e321e4fe92a9f
> Author: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> Date:   Mon Dec 18 20:31:41 2017 +0900
> 
>     mm,vmscan: Make unregister_shrinker() no-op if register_shrinker() failed.
>     
>     Syzbot caught an oops at unregister_shrinker() because combination of
>     commit 1d3d4437eae1bb29 ("vmscan: per-node deferred work") and fault
>     injection made register_shrinker() fail and the caller of
>     register_shrinker() did not check for failure.
> ....

-- 
Michal Hocko
SUSE Labs