linux-kernel - Re: [PATCH] isdn: avm: Handle return value of skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171219.110458.1026495632388180098.davem@davemloft.net>
Date:   Tue, 19 Dec 2017 11:04:58 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     arvind.yadav.cs@...il.com
Cc:     isdn@...ux-pingi.de, stephen@...workplumber.org,
        johannes.berg@...el.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] isdn: avm: Handle return value of skb_dequeue()

From: Arvind Yadav <arvind.yadav.cs@...il.com>
Date: Sun, 17 Dec 2017 01:17:23 +0530

> skb_dequeue() will return NULL for an empty list or a pointer
> to the head element.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

There is no code path where this is possible.

The two call sites:

1) Explicitly add an SKB to the queue

OR

2) Explcitily guard the call with an skb_queue_empty() check

Therefore the stated condition is not possible.