linux-kernel - Re: [PATCH] swiotlb: suppress warning when __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Dec 2017 19:06:43 +0100
From:   Christian König <christian.koenig@....com>
To:     Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        linux-kernel@...r.kernel.org
Cc:     Mike Galbraith <efault@....de>
Subject: Re: [PATCH] swiotlb: suppress warning when __GFP_NOWARN is set.

Am 19.12.2017 um 15:52 schrieb Konrad Rzeszutek Wilk:
> On December 19, 2017 9:32:55 AM EST, "Christian König" <ckoenig.leichtzumerken@...il.com> wrote:
>> TTM tries to allocate coherent memory in chunks of 2MB first to improve
>> TLB efficiency and falls back to allocating 4K pages if that fails.
>>
>> Suppress the warning when the 2MB allocations fails since there is a
>> valid fall back path.
>>
>> Signed-off-by: Christian König <christian.koenig@....com>
> Is there an Reported by or such needed?

Sorry my fault not to include that.

Reported-by: Mike Galbraith <efault@....de>.

>> ---
>> lib/swiotlb.c | 8 +++++---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/lib/swiotlb.c b/lib/swiotlb.c
>> index cea19aaf303c..63a44fb29ce6 100644
>> --- a/lib/swiotlb.c
>> +++ b/lib/swiotlb.c
>> @@ -769,9 +769,11 @@ swiotlb_alloc_coherent(struct device *hwdev,
>> size_t size,
>> 	return ret;
>>
>> err_warn:
>> -	pr_warn("swiotlb: coherent allocation failed for device %s
>> size=%zu\n",
>> -		dev_name(hwdev), size);
>> -	dump_stack();
>> +	if (!(flags & __GFP_NOWARN)) {
>> +		pr_warn("swiotlb: coherent allocation failed for device %s
>> size=%zu\n",
>> +			dev_name(hwdev), size);
>> +		dump_stack();
>> +	}
> Ok, let me queue it up.

Thanks,
Christian.

>> 	return NULL;
>> }