linux-kernel - [RFC PATCH 42/60] hyper_dmabuf: always generate a new random keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Dec 2017 11:29:58 -0800
From:   Dongwon Kim <dongwon.kim@...el.com>
To:     linux-kernel@...r.kernel.org
Cc:     dri-devel@...ts.freedesktop.org, xen-devel@...ts.xenproject.org,
        mateuszx.potrola@...el.com, dongwon.kim@...el.com
Subject: [RFC PATCH 42/60] hyper_dmabuf: always generate a new random keys

From: Mateusz Polrola <mateuszx.potrola@...el.com>

Need to update random keys when reusing hyper_dmabuf_id
in the list to increase security

Signed-off-by: Dongwon Kim <dongwon.kim@...el.com>
---
 drivers/xen/hyper_dmabuf/hyper_dmabuf_id.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/xen/hyper_dmabuf/hyper_dmabuf_id.c b/drivers/xen/hyper_dmabuf/hyper_dmabuf_id.c
index f59dee3..cccdc19 100644
--- a/drivers/xen/hyper_dmabuf/hyper_dmabuf_id.c
+++ b/drivers/xen/hyper_dmabuf/hyper_dmabuf_id.c
@@ -120,10 +120,11 @@ hyper_dmabuf_id_t hyper_dmabuf_get_hid(void)
 	 */
 	if (hid.id == -1 && count < HYPER_DMABUF_ID_MAX) {
 		hid.id = HYPER_DMABUF_ID_CREATE(hyper_dmabuf_private.domid, count++);
-		/* random data embedded in the id for security */
-		get_random_bytes(&hid.rng_key[0], 12);
 	}
 
+	/* random data embedded in the id for security */
+	get_random_bytes(&hid.rng_key[0], 12);
+
 	return hid;
 }
 
-- 
2.7.4