linux-kernel - Re: [PATCH v4 5/5] iommu/vt-d: Add debugfs support for Interrupt remapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1513730591.31078.25.camel@intel.com>
Date:   Wed, 20 Dec 2017 00:42:39 +0000
From:   "Mehta, Sohil" <sohil.mehta@...el.com>
To:     "joro@...tes.org" <joro@...tes.org>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "alex.williamson@...hat.com" <alex.williamson@...hat.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Raj, Ashok" <ashok.raj@...el.com>,
        "Yu, Fenghua" <fenghua.yu@...el.com>,
        "baolu.lu@...ux.intel.com" <baolu.lu@...ux.intel.com>,
        "jacob.jun.pan@...ux.intel.com" <jacob.jun.pan@...ux.intel.com>,
        "iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
        "Kammela, Gayatri" <gayatri.kammela@...el.com>,
        "Shankar, Ravi V" <ravi.v.shankar@...el.com>,
        "dwmw2@...radead.org" <dwmw2@...radead.org>
Subject: Re: [PATCH v4 5/5] iommu/vt-d: Add debugfs support for Interrupt
 remapping


On Tue, 2017-12-19 at 23:30 +0200, Andy Shevchenko wrote:
> On Tue, 2017-12-19 at 13:08 -0800, Sohil Mehta wrote:
> > 
> > Debugfs extension for Intel IOMMU to dump Interrupt remapping table
> > entries for Interrupt remapping and Interrupt posting.
> > 
> > The file /sys/kernel/debug/intel_iommu/ir_translation_struct
> > provides
> > detailed information, such as Index, Source Id, Destination Id,
> > Vector
> > and the raw values for entries with the present bit set, in the
> > format
> > shown.
> > 
> > Remapped Interrupt supported on IOMMU: dmar5
> >  IR table address:ffff93e09d54c310
> > -----------------------------------------------------------
> >  Index  SID  Dest_ID  Vct Raw_value_high   Raw_value_low
> >  1      3a00 00000600 2c  0000000000043a00 00000600002c0009
> >  111    4301 00000900 a2  0000000000044301 0000090000a20009
> > 
> > Posted Interrupt supported on IOMMU: dmar5
> >  IR table address:ffff93e09d54c310
> > -----------------------------------------------------------------
> > ---
> >  Index  SID  PDA_high PDA_low  Vct Raw_value_high   Raw_value_low
> >  4      4300 00000010 40c7c880 41  0000001000044300
> > 40c7c88000418001
> >  5      4300 00000010 40c7c880 51  0000001000044300
> > 40c7c88000518001
> > 
> > 
> > 
> > +		seq_printf(m, "\nRemapped Interrupt supported on
> > IOMMU: %s\n"
> Please, avoid leading \n.

Sure. I'll add a separate seq_puts(m, "\n") after each of the loops to
avoid having the leading '\n's.

> 
> > 
> > +			   " IR table address:%p\n", iommu->name,
> > +			   iommu->ir_table);
> > +
> > +		seq_puts(m, "-------------------------------------
> > -
> > ---------"
> > +			 "------------\n");
> It's okay to use long string literal on one line. So, don't split (or
> for multi-line string literals, split by \n like you do above).
> 
Thanks. Will fix this and the other one.

> > 
> > +	seq_puts(m,
> > "\n****\t****\t****\t****\t****\t****\t****\t****\n");
> Leading \n.
> 
> > 
> > +		seq_printf(m, "\nPosted Interrupt supported on
> > IOMMU:
> > %s\n"
> Ditto.
> 
> > 
> > +			   " IR table address:%p\n", iommu->name,
> > +			   iommu->ir_table);
> > +
> > +		seq_puts(m, "-------------------------------------
> > -
> > ----------"
> > +			 "--------------------\n");
> Join back.
>