linux-kernel - Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Dec 2017 09:17:43 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Long Li <longli@...rosoft.com>
Cc:     Steve French <sfrench@...ba.org>,
        Pavel Shilovskiy <pshilov@...rosoft.com>,
        Jean Delvare <jdelvare@...e.de>,
        "linux-cifs@...r.kernel.org" <linux-cifs@...r.kernel.org>,
        "samba-technical@...ts.samba.org" <samba-technical@...ts.samba.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

On Tue, Dec 19, 2017 at 10:21 PM, Long Li <longli@...rosoft.com> wrote:
>>       depends on CIFS && INFINIBAND
>> +     depends on CIFS=m || INFINIBAND=y
>
> How about we change them to
>
>         depends on CIFS=m && INFINIBAND || CIFS=y && INFINIBAND=y
>
> This makes it easy to read.

Yes, that seems fine. I would normally group them using () to avoid
any confusion with operator precedence, but your version is
also correct, so just pick the one you like best.

       Arnd